Skip to content

refactor: Avoid once_cell on new Rust#253

Merged
epage merged 1 commit intorust-cli:mainfrom
epage:once
May 22, 2025
Merged

refactor: Avoid once_cell on new Rust#253
epage merged 1 commit intorust-cli:mainfrom
epage:once

Conversation

@epage
Copy link
Copy Markdown
Collaborator

@epage epage commented May 22, 2025

This supersedes #251

@epage epage enabled auto-merge May 22, 2025 01:49
@epage epage merged commit f20e5ba into rust-cli:main May 22, 2025
18 checks passed
@epage epage deleted the once branch May 22, 2025 01:49
@epage epage mentioned this pull request May 22, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15176229152

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.266%

Totals Coverage Status
Change from base Build 15069570022: 0.0%
Covered Lines: 1234
Relevant Lines: 2361

💛 - Coveralls

@2ndDerivative
Copy link
Copy Markdown

I'm still wondering how this changes anything. If I compile with higher Rust this doesn't exclude once_cell, as the 1.56 version of the polyfill crate just passes through too

@epage
Copy link
Copy Markdown
Collaborator Author

epage commented May 22, 2025

If your MSRV is 1.70 or later, then you can use once_cell_polyfill@1.70.1 and not depend on once_cell.

If your MSRV is below 1.70, then you are in luck, we still support you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants